[C++][Lua][sql] Expeditionary Force with Kolshushu region enabled#10278
Open
Nobutadas wants to merge 7 commits into
Open
[C++][Lua][sql] Expeditionary Force with Kolshushu region enabled#10278Nobutadas wants to merge 7 commits into
Nobutadas wants to merge 7 commits into
Conversation
ac4e35b to
e257320
Compare
e257320 to
551061f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This pull request implements the Expeditionary Force feature with only one region, the Kolshushu region. Once the overall flow has been verified, the remainder of the regions will be implemented.
This PR is split into different commits that are independent steps in the Expeditionary Force PR. Each one of the commits can be it's own PR that build off of each other.
The overall flow of Expeditionary Force can be seen in the captures below. Recordings will demonstrate signup, flow of the banners, as well as turning in at the end of the tally.
Steps to test these changes
An entire test plan was developed to test this feature. Located at https://docs.google.com/document/d/1OrlcOkArFUCCBeQB5HzSWt3SfA0dn1iK/edit?usp=sharing&ouid=100883804802821106095&rtpof=true&sd=true
Influence Justification
Influence gain is set in the main.lua setting file. Justification for the influence is provided here: https://docs.google.com/document/d/19QsHuPX8kKZuJSqWfKb-jSV3wv7Ivkje9ZYeI9ZDlJ4/edit?usp=sharing
Captures
All captures are done as Bastok.
Buburimu Peninsula
https://youtu.be/l9DzBCHJxr8
Capture: https://drive.google.com/file/d/1szyT6BYfNTdI4UBYFExiy_pFMZMwrCIh/view?usp=sharing
Capture of a group of 4 doing Expeditionary Force for Bastok when it was in third place in Buburimu Peninsula. We wiped once and then cleared it another time.
Buburimu Peninsula
Capture: https://drive.google.com/file/d/1aptoq5gOyY7UojP3DpxfVOMR1ceZDr1l/view?usp=drive_link
Video 1: https://youtu.be/B_SVTXtci9w
Video 2: https://youtu.be/vl-E0Vs7r70
Solo spawning EF battles for Bastok in Buburimu Peninsula to get banner spawns, monster spawns, and monster levels.
Treasure Chests - The Maze
Capture: https://drive.google.com/file/d/1hyVWyHZlIXIS3AdvgmXi_0yh6vpy7bE8/view?usp=drive_link
Video: https://youtu.be/3DX6PpWwin0
Opened 9 coffers to track influence gain. Note, I did open 1 coffer 2 days ago.
I'm not sure if the trend down in influence gain is because of repeated opening of coffers OR because Bastok's ranking has increased.
Expeditionary Force (Bastok) - Attempt to turn in old key item (previous week) to outpost NPC
https://youtu.be/l-70X3i2Q98
Capture: https://drive.google.com/file/d/1P6svKDXLMZm3PVPJTJOzFCAw-B61WLol/view?usp=sharing
Note: They didnt take it.
Expeditionary Force (Bastok) - Valkurm Dunes + Xarcabard
https://youtu.be/uuk4aSnlES4
Capture: https://drive.google.com/file/d/1zN2l2B8aRyUAg8i1c3KZ2Dwg8C1lT8nX/view?usp=sharing
Expeditionary Force (Bastok) - Attempted to turn in old KI to Jeuno guard (no take), zone guard (no take), opened chest for influence, still can trigger banners, and turned in KI to embassy guard in Windurst
https://drive.google.com/file/d/1XiKay-p_zIVBPB80243vpqUbgb9lMBaY/view?usp=drive_link
https://youtu.be/wr8rDesUaNY
https://youtu.be/vaVH00FWHWY
Expeditionary Force (Bastok) - Valkurm Dunes + Xarcabard from a non-Bastok (for half) player. It mirrors Kipling's capture above.
https://youtu.be/lBNlgznk_xM
Capture: https://drive.google.com/file/d/1PtyPYbbVMKLeLgUShDYWsG91Ur4gYk_6/view?usp=drive_link
Expeditionary Force (Bastok) - Beaucedine Glacier + Cape Terrigan
https://youtu.be/UliVwqkLRNM
Capture: https://drive.google.com/file/d/103ekoyfjW3A7I_GWk39vivPU0LP6XSDF/view?usp=sharing
Expeditionary Force (Bastok) - Beaucedine Glacier + Cape Terrigan (Same as Kipling's above from another PoV)
Capture: https://drive.google.com/file/d/112OqWeZc27rpHqe71SJUDkxF0dnLW8Jl/view?usp=drive_link
https://youtu.be/1cwPNbnQqwY
Expeditionary Force - Banner locations for all zones except Junger, Qufim, and Eastern Altepa
Screenshot Files: https://drive.google.com/file/d/1QOVac-LLcGw8EooHTM-EKHvpBQTrsnPg/view?usp=drive_link
Expeditionary Force - Solo Spawning Flags
Zones: Beaucedine Glacier, Cape Teriggan, Eastern Altepa Desert, Meriphataud Mountains, Pashhow Marshlands, The Sanctuary of Zi'Tah, Valkurm Dunes, Xarcabard, Yhoator Jungle, Yhutunga Jungle
I solo spawned the mobs at the banners, died, and repeated until I discovered all 5 banners for the zone.
Capture: https://drive.google.com/file/d/1wlzjEEqKvCoPNL5fhsla-cTXGSjnALZL/view?usp=drive_link
Expeditionary Force (Bastok) - Zulkheim region - Conquest Influence Test against Coffer
Leveled a character from 7 to 34 in the region, died in the middle. Then I opened a coffer. Leveling had just below a 1% swing. Coffer had about a 2% swing.
https://drive.google.com/file/d/1edFGvLuwAKTZJFRC_3JE5oKnKpj4qRZv/view?usp=drive_link
Expeditionary Force (Bastok) - End of Tally Turn in
I tested 3 things in this capture.
Opening a coffer with a KI in a region you now own (nothing happened).
Turning in the key items with 2 regions now owned.
Swapping nations with KI in inventory.
https://youtu.be/Lcw7DhtaExY
Capture: https://drive.google.com/file/d/1A6-QsEDFtK9Wzifk_juDU4_M55AXlU_V/view?usp=drive_link
Expeditionary Force - Junger and Altepa Banner Spawning
Just running to a flag, spawning mobs, and dying.
Capture: https://drive.google.com/file/d/1NbQElIQVQ09KkKn3sG8wqgUdMtnrqM61/view?usp=drive_link
Screenshot Files of Banners: https://drive.google.com/file/d/1Kvs2qMe6Mw4rLAuwlDnVetvbLGVkOKo4/view?usp=drive_link